codecov-io commented on issue #3821: Refactor SegmentNameGenerators and integrate them into Hadoop URL: https://github.com/apache/incubator-pinot/pull/3821#issuecomment-462978060 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3821?src=pr&el=h1) Report > Merging [#3821](https://codecov.io/gh/apache/incubator-pinot/pull/3821?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/eb0d5b68e4a48789192416d0817c2de6b2b4d470?src=pr&el=desc) will **decrease** coverage by `0.12%`. > The diff coverage is `94.02%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3821?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3821 +/- ## ============================================ - Coverage 67.19% 67.07% -0.13% Complexity 4 4 ============================================ Files 1027 1029 +2 Lines 50816 50775 -41 Branches 7091 7092 +1 ============================================ - Hits 34147 34058 -89 - Misses 14333 14387 +54 + Partials 2336 2330 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3821?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../pinot/core/segment/name/SegmentNameGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3821/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L25hbWUvU2VnbWVudE5hbWVHZW5lcmF0b3IuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | | | [.../core/segment/name/SimpleSegmentNameGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3821/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L25hbWUvU2ltcGxlU2VnbWVudE5hbWVHZW5lcmF0b3IuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...indexsegment/generator/SegmentGeneratorConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/3821/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvZ2VuZXJhdG9yL1NlZ21lbnRHZW5lcmF0b3JDb25maWcuamF2YQ==) | `60.47% <100%> (-0.47%)` | `0 <0> (ø)` | | | [...t/creator/impl/SegmentIndexCreationDriverImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/3821/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50SW5kZXhDcmVhdGlvbkRyaXZlckltcGwuamF2YQ==) | `89.62% <100%> (+0.17%)` | `0 <0> (ø)` | :arrow_down: | | [...t/core/segment/name/FixedSegmentNameGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3821/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L25hbWUvRml4ZWRTZWdtZW50TmFtZUdlbmVyYXRvci5qYXZh) | `80% <80%> (ø)` | `0 <0> (?)` | | | [...gment/name/NormalizedDateSegmentNameGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3821/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L25hbWUvTm9ybWFsaXplZERhdGVTZWdtZW50TmFtZUdlbmVyYXRvci5qYXZh) | `93.02% <93.02%> (+18.82%)` | `0 <0> (ø)` | :arrow_down: | | [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/3821/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh) | `20.28% <0%> (-59.43%)` | `0% <0%> (ø)` | | | [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3821/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `28.57% <0%> (-35.17%)` | `0% <0%> (ø)` | | | [...he/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/3821/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvVmFsaWRTZWdtZW50UHJ1bmVyLmphdmE=) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | | | [...egation/function/customobject/MinMaxRangePair.java](https://codecov.io/gh/apache/incubator-pinot/pull/3821/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9jdXN0b21vYmplY3QvTWluTWF4UmFuZ2VQYWlyLmphdmE=) | `75.86% <0%> (-24.14%)` | `0% <0%> (ø)` | | | ... and [33 more](https://codecov.io/gh/apache/incubator-pinot/pull/3821/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3821?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3821?src=pr&el=footer). Last update [eb0d5b6...1a5b4ff](https://codecov.io/gh/apache/incubator-pinot/pull/3821?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org For additional commands, e-mail: dev-h...@pinot.apache.org
