+1 [binding] On Fri, Aug 13, 2021 at 1:30 PM Yupeng Fu <yupeng...@gmail.com> wrote:
> +1 > > On Thu, Aug 12, 2021 at 6:53 PM Xiang Fu <fx19880...@gmail.com> wrote: > >> +1 >> >> I’m using maven 3.6.2 and validated both jdk8/11. >> >> >> On Aug 12, 2021, at 4:53 PM, Yupeng Fu <yupeng...@gmail.com> wrote: >> >> Thanks for updating the notes. >> >> I upgraded maven from 3.3 to 3.8, and I can successfully build the >> release. >> >> Thanks, >> >> On Thu, Aug 12, 2021 at 4:20 PM Seunghyun Lee <sn...@apache.org> wrote: >> >>> @Yupeng, >>> >>> I added partial upsert support to the release note. For the compilation >>> issue, I will wait for more people to validate to see if it's the real >>> issue. >>> >>> Meanwhile, can you try to compile the code with more recent version of >>> maven? >>> >>> Best, >>> Seunghyun >>> >>> On Thu, Aug 12, 2021 at 3:11 PM Yupeng Fu <yupeng...@gmail.com> wrote: >>> >>>> Also, in the release note, could you include the partial upsert >>>> support? It's an important feature added to upsert. >>>> >>>> Thanks, >>>> >>>> On Thu, Aug 12, 2021 at 3:10 PM Yupeng Fu <yupeng...@gmail.com> wrote: >>>> >>>>> Not sure if it's just me. I got maven compilation failure with >>>>> >>>>> [WARNING] Error injecting: >>>>> org.apache.maven.artifact.installer.DefaultArtifactInstaller >>>>> com.google.inject.ProvisionException: Unable to provision, see the >>>>> following errors: >>>>> >>>>> 1) Error injecting: private org.eclipse.aether.spi.log.Logger >>>>> org.apache.maven.repository.internal.DefaultVersionRangeResolver.logger >>>>> while locating >>>>> org.apache.maven.repository.internal.DefaultVersionRangeResolver >>>>> while locating java.lang.Object annotated with * >>>>> at org.eclipse.sisu.wire.LocatorWiring >>>>> while locating org.eclipse.aether.impl.VersionRangeResolver >>>>> for parameter 2 at >>>>> org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.<init>(Unknown >>>>> Source) >>>>> while locating >>>>> org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector >>>>> while locating java.lang.Object annotated with * >>>>> at org.eclipse.sisu.wire.LocatorWiring >>>>> while locating org.eclipse.aether.impl.DependencyCollector >>>>> for parameter 5 at >>>>> org.eclipse.aether.internal.impl.DefaultRepositorySystem.<init>(Unknown >>>>> Source) >>>>> while locating >>>>> org.eclipse.aether.internal.impl.DefaultRepositorySystem >>>>> while locating java.lang.Object annotated with * >>>>> while locating >>>>> org.apache.maven.artifact.installer.DefaultArtifactInstaller >>>>> Caused by: java.lang.IllegalArgumentException: Can not set >>>>> org.eclipse.aether.spi.log.Logger field >>>>> org.apache.maven.repository.internal.DefaultVersionRangeResolver.logger to >>>>> org.eclipse.aether.internal.impl.slf4j.Slf4jLoggerFactory >>>>> at >>>>> java.base/jdk.internal.reflect.UnsafeFieldAccessorImpl.throwSetIllegalArgumentException(UnsafeFieldA >>>>> ... >>>>> >>>>> [ERROR] at org.apache.maven.cli.MavenCli.main(MavenCli.java:199) >>>>> [ERROR] at >>>>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native >>>>> Method) >>>>> [ERROR] at >>>>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) >>>>> [ERROR] at >>>>> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>> [ERROR] at java.base/java.lang.reflect.Method.invoke(Method.java:566) >>>>> [ERROR] at >>>>> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289) >>>>> [ERROR] at >>>>> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229) >>>>> [ERROR] at >>>>> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415) >>>>> [ERROR] at >>>>> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356) >>>>> [ERROR] >>>>> [ERROR] 4 errors >>>>> [ERROR] role: org.apache.maven.plugin.Mojo >>>>> [ERROR] roleHint: >>>>> org.apache.maven.plugins:maven-install-plugin:2.5.2:install >>>>> [ERROR] -> [Help 1] >>>>> [ERROR] >>>>> [ERROR] To see the full stack trace of the errors, re-run Maven with >>>>> the -e switch. >>>>> [ERROR] Re-run Maven using the -X switch to enable full debug logging. >>>>> [ERROR] >>>>> >>>>> On Thu, Aug 12, 2021 at 2:49 PM Xiaotian Jiang <jackie....@gmail.com> >>>>> wrote: >>>>> >>>>>> +1 >>>>>> >>>>>> Jackie >>>>>> >>>>>> On Wed, Aug 11, 2021 at 4:03 PM Seunghyun Lee <sn...@apache.org> >>>>>> wrote: >>>>>> >>>>>>> Hi Pinot Community, >>>>>>> >>>>>>> This is a call for a vote to release Apache Pinot 0.8.0. >>>>>>> >>>>>>> The release candidate: >>>>>>> https://dist.apache.org/repos/dist/dev/pinot/apache-pinot-0.8.0-rc0 >>>>>>> >>>>>>> Git tag for this release: >>>>>>> https://github.com/apache/pinot/tree/release-0.8.0-rc0 >>>>>>> >>>>>>> Git hash for this release: >>>>>>> c4ceff06d21fc1c1b88469a8dbae742a4b609808 >>>>>>> >>>>>>> The artifacts have been signed with key: 7199AF89, which can be >>>>>>> found in the following KEYS file. >>>>>>> https://dist.apache.org/repos/dist/release/pinot/KEYS >>>>>>> >>>>>>> Release notes: >>>>>>> https://github.com/apache/pinot/releases/tag/release-0.8.0-rc0 >>>>>>> >>>>>>> Staging repository: >>>>>>> >>>>>>> https://repository.apache.org/content/repositories/orgapachepinot-1030 >>>>>>> >>>>>>> Documentation on verifying a release candidate: >>>>>>> >>>>>>> https://cwiki.apache.org/confluence/display/PINOT/Validating+a+release+candidate >>>>>>> >>>>>>> The vote will be open for at least 72 hours or until a necessary >>>>>>> number of votes is reached. >>>>>>> >>>>>>> Please vote accordingly, >>>>>>> >>>>>>> [ ] +1 approve >>>>>>> [ ] +0 no opinion >>>>>>> [ ] -1 disapprove with the reason >>>>>>> >>>>>>> Thanks, >>>>>>> Apache Pinot team >>>>>>> >>>>>> >>>>> >>>>> -- >>>>> --Yupeng >>>>> >>>> >>>> >>>> -- >>>> --Yupeng >>>> >>> >> >> -- >> --Yupeng >> >> >> > > -- > --Yupeng >
