I concur. On Mon, Aug 15, 2016 at 8:37 PM, Ellison Anne Williams < eawilliamsp...@gmail.com> wrote:
> With Suneel's pom updates to remove the offending openjdk files from > apache-pirk-0.1.0-incubating-sources.jar, the only remaining issue is the > jboss-logging license issue. > > This appears to be resolved via the Apache Licensing rules in the last > email and via placing documentation similar to Spark's in the NOTICE file. > Mentors - Please confirm that this is the case. > > If these are settled, then we just have to update our NOTICE and LICENSE > files. > > On Mon, Aug 15, 2016 at 3:25 PM, Ellison Anne Williams < > eawilliamsp...@gmail.com> wrote: > > > Ok - after a bit of digging, here is what I found on the > > apache-pirk-0.1.0-incubating-exe.jar issue with the phantom > jboss-logging > > license file. > > > > The culprit is netty. If you take a look at META-INF/maven/io.netty/netty > > when you unjar, you will see the netty pom which contains the following: > > > > <!-- Logging frameworks - completely optional --> > > > > ......(dependencies for other logging frameworks)..... > > > > <dependency> > > > > <groupId>org.jboss.logging</groupId> > > > > <artifactId>jboss-logging-spi</artifactId> > > > > <version>2.1.2.GA</version> > > > > <scope>compile</scope> > > > > <optional>true</optional> > > > > </dependency> > > > > This is pulled in from Spark and other Hadoop places. > > > > Reading the Apache Licensing info carefully, it appears that it is *not* > a > > licensing issue as the code does not distribute it and it is used only > for > > optional features. See http://www.apache.org/legal/ > > resolved.html#prohibited and http://www.apache.org/ > > legal/resolved.html#optional. > > > > Also, Spark deals with it in its NOTICE file as follows ( > > https://github.com/apache/spark/blob/master/NOTICE): > > > > This product optionally depends on 'JBoss Logging', a logging framework, > > which can be obtained at: > > > > * LICENSE: > > * license/LICENSE.jboss-logging.txt (GNU LGPL 2.1) > > * HOMEPAGE: > > * http://anonsvn.jboss.org/repos/common/common-logging-spi/ > > > > > > Thus, it seems that we can stand on the Apache Licensing rules and follow > > Spark's lead and include similar language in our NOTICE file. > > > > Can we make the same argument about the org.openjdk.jmh.infra. > generated.* > > files in the apache-pirk-0.1.0-incubating-sources.jar? If so, we can > make > > them part of the RAT exclusions and that solve that issue. > > > > From there, cleaning up the LICENSE and NOTICE files as previously > pointed > > out in the thread should do it. > > > > Thoughts? > > > > On Mon, Aug 15, 2016 at 12:46 PM, Tim Ellison <t.p.elli...@gmail.com> > > wrote: > > > >> On 14/08/16 04:19, Ellison Anne Williams wrote: > >> > All JIRAs completed for this release are tagged with 'FixVersion = > >> 0.1.0'. > >> > You can view them here: https://issues.apache.org/jira > >> /browse/PIRK-47?jql= > >> > project%20%3D%20PIRK%20AND%20fixVersion%20%3D0.1.0 > >> > >> BTW (just so you don't inadvertently send that URL to the > >> general@incubator.a.o list vote). > >> > >> That URL points to one specific JIRA issue. The release notes URL is: > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje > >> ctId=12320320&version=12338109 > >> > >> Regards, > >> Tim > >> > >> > >> > > >
