Github user tellison commented on a diff in the pull request:

    https://github.com/apache/incubator-pirk/pull/69#discussion_r75324702
  
    --- Diff: 
src/main/java/org/apache/pirk/responder/wideskies/spark/ComputeResponse.java ---
    @@ -316,23 +311,15 @@ public void performQuery() throws Exception
     
       /**
        * Method to perform the query given an input RDD of MapWritables
    -   * 
    +   *
        */
       public void performQuery(JavaRDD<MapWritable> inputRDD) throws 
PIRException
       {
         logger.info("Performing query: ");
     
    -    // If we are using distributed exp tables -- Create the expTable file 
in hdfs for this query, if it doesn't exist
    -    if ((queryInfo.getUseHDFSExpLookupTable() || useHDFSLookupTable) && 
query.getExpFileBasedLookup().isEmpty())
    -    {
    -      // <queryHash, <<power>,<element^power mod N^2>>
    -      JavaPairRDD<Integer,Iterable<Tuple2<Integer,BigInteger>>> 
expCalculations = ComputeExpLookupTable.computeExpTable(sc, fs, bVars, query, 
queryInput,
    --- End diff --
    
    Is this removal safe?  Although the return value is ignored, the compute 
method has the side-effect of creating the exponent look-up table in HDFS, and 
storing it in the Query.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to