Github user clharris commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/84#discussion_r76901301
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/storm/EncColMultBolt.java ---
@@ -103,13 +101,13 @@ public void execute(Tuple tuple)
// Data tuple received. Do column multiplication.
long colIndex =
tuple.getLongByField(StormConstants.COLUMN_INDEX_ERC_FIELD);
- colVal1 = (BigInteger)
tuple.getValueByField(StormConstants.ENCRYPTED_VALUE_FIELD);
+ BigInteger colVal1 = (BigInteger)
tuple.getValueByField(StormConstants.ENCRYPTED_VALUE_FIELD);
logger.debug("Received tuple in ECM, multiplying {} to col {}",
colVal1, colIndex);
if (resultsMap.containsKey(colIndex))
{
- colMult = colVal1.multiply(resultsMap.get(colIndex));
+ BigInteger colMult = colVal1.multiply(resultsMap.get(colIndex));
resultsMap.put(colIndex, colMult.mod(nSquared));
--- End diff --
Will initializing colVal1 and colMult inside execute lead to extra garbage
collection time? I mean not much per instance, but execute gets called billions
of times.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
