Github user ellisonanne commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/93#discussion_r80037087
--- Diff:
src/main/resources/META-INF/services/org.apache.pirk.responder.wideskies.spi.ResponderPlugin
---
@@ -0,0 +1,5 @@
+org.apache.pirk.responder.wideskies.mapreduce.MapReduceResponder
--- End diff --
My concern is that instead of keeping this code 'dumb' and forcing the user
to give the specific ResponderLauncher implementation via the CLI (or props
file), the PR seems to have moved to a service-plugin model where not only does
the user have to specify the class/platform, the code has to be aware, via a
static list, of the possible plugin implementations (as listed in
org.apache.pirk.responder.wideskies.spi.ResponderPlugin). While this is far
more flexible than the way that the platform selection was previously
implemented, it does not remove the need for the codebase to understand (in one
location) all of it's possible platforms. I am not opposed (as you pointed out,
it is a well known model), but I thought that one of the primary goals was to
remove the need for a static, central awareness of all possible platforms.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
