Github user smarthi commented on a diff in the pull request:

    https://github.com/apache/incubator-pirk/pull/115#discussion_r85682703
  
    --- Diff: src/main/java/org/apache/pirk/test/utils/BaseTests.java ---
    @@ -51,9 +51,9 @@
       public static final int dataPartitionBitSize = 8;
     
       // Selectors for domain and IP queries, queryIdentifier is the first 
entry for file generation
    -  private static ArrayList<String> selectorsDomain = new ArrayList<>(
    +  public static ArrayList<String> selectorsDomain = new ArrayList<>(
           Arrays.asList("s.t.u.net", "d.e.com", "r.r.r.r", "a.b.c.com", 
"something.else", "x.y.net"));
    -  private static ArrayList<String> selectorsIP = new 
ArrayList<>(Arrays.asList("55.55.55.55", "5.6.7.8", "10.20.30.40", 
"13.14.15.16", "21.22.23.24"));
    +  public static ArrayList<String> selectorsIP = new 
ArrayList<>(Arrays.asList("55.55.55.55", "5.6.7.8", "10.20.30.40", 
"13.14.15.16", "21.22.23.24"));
    --- End diff --
    
    Generic interface List<> on LHS


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to