I'll fix the ResultListTest issue. The others are old warnings that can be ignored. Thanks, G
On Feb 11, 2010, at 8:19 PM, Sandro Martini wrote: > Hi to all, > as any release approaching, the usual list of small things to fix (all > Normal Priority, so not very important :-) ), as suggested by > FindBugs: > > ResultListTest.java:37 > org.apache.pivot.tests.sql.ResultListTest.main(String[]) may fail to > close Statement > ResultListTest.java:36 > org.apache.pivot.tests.sql.ResultListTest.main(String[]) may fail to > close Connection > A try/catch/finally (and here a nested try/finally) should be enough > ... mainly to give our users a feedback of good code. > > ComponentPropertyInspectorSkin.java:31 > org.apache.pivot.tools.wtk.ComponentPropertyInspectorSkin$NameComparator > implements Comparator but not Serializable > ComponentPropertyInspectorSkin.java:38 > org.apache.pivot.tools.wtk.ComponentPropertyInspectorSkin$ClassComparator > implements Comparator but not Serializable > EventLoggerSkin.java:44 > org.apache.pivot.tools.wtk.EventLoggerSkin$TreeNodeComparator > implements Comparator but not Serializable > TreeNodeComparator.java:1 > org.apache.pivot.tutorials.TreeNodeComparator implements Comparator > but not Serializable > TreeView.java:610 org.apache.pivot.wtk.TreeView$PathComparator > implements Comparator but not Serializable > > ValueSeries.java:1 org.apache.pivot.charts.content.ValueSeries doesn't > override org.apache.pivot.collections.ArrayList.equals(Object) > This tells that ValueSeries extends ArrayList and add a field, but it > doesn't define an equals ... > > > Tell me if I have to fix them, many weeks are passed since my last > commit, and now could be a good time to restart :-) . > > Bye, > Sandro
