Hi Chris, good work here :-) , my comments under. 1 - I think for the 2.0 we should handle it in the right and generic way
2 - On Windows <Shift><Alt><Tab> move backwards on the running tasks, and as a general rule (as in many graphics applications): -- <Shift> reverse the operation triggered without it (of all other keys), or in a multi-selection context (List, Table, Tree) does a range selection on/off (the previous cursor position to the current) -- <Ctrl> the default modifier for shortcuts, or in a multi-selection context (List, Table, Tree) add a single element selection on/off (the element on the current cursor position) -- <Alt> less used (by default), so applications can use it ... > My point here was that unless the intent was to process focus traversal when > ALT/META/CTRL are also pressed, then it is better to check what modifiers are > pressed and only proceed if the (optional) SHIFT modifier is pressed or none > at all. I agree with you. 3 - I agree with you. 4 - Yes, and why not also on TerraTableViewSkin ? > What would be the use case? Checkboxes are often used as a more > "user-friendly" alternative to multi-select lists - it is less common to see > them combined. I have many (web) applications where using checkboxes in a multi-select List (or on a multi-select Table or Tree) are difficult to handle (or the user interaction doesn't like them), so in these cases a multi-selection clicking directly in the element is simpler, also for users ... I'm not saying it's a best practice, but in many cases could be less "confusing" for users, having less elements to click. So if it's not too complex I'd prefer to have also this. on other points I don't have comments (but not because I'm lazy :-) ) ... 7 - A last note, probably unnecessary, but just to remember it: when should also verify to handle in the right way all function keys (<F1> .. <F12>) standalone, or combined with other modifiers ... 8 - And, important, on handling Home/End, Page Up/Down and combinations with <Ctrl>, <Shift>, <Alt> discussed yesterday, how is the sate of the art for Pivot 2.x ? I'm thinking on changing selection using these combinations (if I remember well yesterday Greg and Todd said that they prefer to change the viewport but not the selection with them) ... but at least having a dedicated style that enable this behavior ? And the same for some on Trees as seen yesterday (including some interesting usage of arrow keys). Sorry if I write another time on this but from my experience these are really time-saver features ... and many applications uses them so probably many users expect this. What do you think ? Or if not in the standard behavior, would it be possible to define them in some "helper" classes are reuse on many components when desired ? 9 - in Text components the key <Insert> is not handled (toggle on/off the overwriting of next chars), open an issue ? Bye, Sandro
