[ 
https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006911#comment-13006911
 ] 

Greg Brown commented on PIVOT-713:
----------------------------------

> If there are other issues I'm not against removing the final qualifier, but 
> probably we should see what real cases are requiring it.

The use case is the builder pattern. A similar issue came up a couple months 
back when a Java-based builder pattern was suggested. Unless all of these 
classes are made non-final, such patterns cannot be universally employed.

I suggest that you generate a list of static final classes and attach it to 
this issue for review.




> Consider making some inner classes non-final
> --------------------------------------------
>
>                 Key: PIVOT-713
>                 URL: https://issues.apache.org/jira/browse/PIVOT-713
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>    Affects Versions: 2.0
>            Reporter: xiefei
>            Assignee: Sandro Martini
>            Priority: Minor
>             Fix For: 2.0.1
>
>         Attachments: patch.patch
>
>
> I am implementing a groovy-builder-like DSL for pivot using scala. In the 
> DSL, I need subclass of each component/container that retains original 
> component/container behavior but is aware of the DSL context as well. All 
> goes well except GridPane.Row.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to