[ 
https://issues.apache.org/jira/browse/PIVOT-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036992#comment-13036992
 ] 

Greg Brown commented on PIVOT-746:
----------------------------------

> re: "location of the method (in ApplicationContext) " 
> I am sorry I was not clear: you already has version in core: 
>    public class Version implements Comparable<Version>, Serializable { 
> why not provide singe static final field in core, which does parsing of build 
> version 

Where would this field live? Certainly not in the Version class itself, since 
Version is a generic class representing a four-value revision number (in other 
words, it isn't specific to Pivot). I don't see any problem leaving it in 
ApplicationContext.

> so nobody knows build.properties exists

In the current implementation, only ApplicationContext needs to know about it. 
How would moving it to another class be any different?

> try using pde: 
> http://www.vogella.de/articles/EclipsePDEBuild/article.html#productbuild

I have. How do you think the Pivot plugin was built?  ;-)


> Add API to return Version of Pivot retrieved from "build.properties"
> --------------------------------------------------------------------
>
>                 Key: PIVOT-746
>                 URL: https://issues.apache.org/jira/browse/PIVOT-746
>             Project: Pivot
>          Issue Type: New Feature
>          Components: wtk
>    Affects Versions: 2.0.1
>         Environment: Windows XP SP3, JDK 1.6.0_16
>            Reporter: Roger Whitcomb
>            Priority: Trivial
>             Fix For: 2.0.1
>
>         Attachments: version.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Would be helpful to be able to determine programmatically what the version of 
> Pivot is.  The simplest method is to include "build.properties" which is the 
> original source of this information in the packaged .jar files and then to 
> provide an API to read and parse this value into a Version structure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to