[
https://issues.apache.org/jira/browse/PIVOT-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050392#comment-13050392
]
Sandro Martini commented on PIVOT-742:
--------------------------------------
Hi all,
patch applied and all my tests (executing many of our Demos) were successful
(even with Web Start), so if there aren't objections, in a few days I'll apply
it. Thank you again to Andrei.
BUT wait a minute:
after applying this patch I see that it's no more possible to set an arbitrary
classloader so this could reopen the issue 687 (
https://issues.apache.org/jira/browse/PIVOT-687 ), so at this point I think we
should leave both ways open:
if used the (new but deprecated ? :-) ) constructor, set a private final
classloader, and in all places here if not null use it, otherwise fallback on
the classloader of this patch ... what do you think ?
In the meantime I'll try to contact Gerrick Bivins (who ask to us the feature
of the issue 687) and ask if the proposed solution could work even for him
(under NetBeans Platform) ...
> pluggable classloader
> ---------------------
>
> Key: PIVOT-742
> URL: https://issues.apache.org/jira/browse/PIVOT-742
> Project: Pivot
> Issue Type: Improvement
> Reporter: Andrei Pozolotin
> Assignee: Sandro Martini
> Fix For: 2.0.1
>
> Attachments: CLPlugin.java, CLPluginTCCL.java, CLProvider.java,
> UseCase.java, patch_2011-06-15_bxml-classloader.patch
>
>
> pluggable classloader:
> 1) in current pivot trunk, TCCL,
> Thread.currentThread().getContextClassLoader().... is mentioned 105 times
> I suggest to centralize it and replace with pluggable classloader (which can
> use TCCL by default);
> 2) review all other uses of Class.getResource(), which are not using TCCL,
> and convert when possible;
> motivation:
> https://issues.apache.org/jira/browse/PIVOT-22
> https://issues.apache.org/jira/browse/FELIX-2951
> http://njbartlett.name/2010/08/30/osgi-readiness-loading-classes.html
> http://wiki.eclipse.org/index.php/Context_Class_Loader_Enhancements
> http://stackoverflow.com/questions/2198928/better-handling-of-thread-context-classloader-in-osgi
> http://mail-archives.apache.org/mod_mbox/pivot-user/201105.mbox/%3c4dcdf889.10...@gmail.com%3E
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
