Thanks again, Chris. I have supplied a new patch that fixes issues 2-4 below.
I'm very grateful that you take the time to test this, it's coming along nicely I think :) -- Edvin > -----Opprinnelig melding----- > Fra: Chris Bartlett [mailto:cbartlet...@gmail.com] > Sendt: 12. august 2011 21:15 > Til: dev@pivot.apache.org > Emne: Re: Does someone have time to check my patch for PIVOT-276? > > Edvin, > > OK, again just the results of a quick look (and the new patch does still work > fine with ComponentExplorer) I'll try to dig a little deeper next time and go > further than just tweaking values in ComponentExplorer. > > 1) Layout looks good now regardless of padding & spacing values > > 2) Changes to the 'horizontalSpacing' and 'verticalSpacing' styles do not > invalidate the component. > see org.apache.pivot.wtk.skin.terra.TerraGridViewSkin.setPadding(Insets) > or similar for other styles that do invalidate when changed You can see this > when you change their values in ComponentExplorer > > 3) Pressing the DOWN arrow can lead to a > java.lang.IndexOutOfBoundsException when there is no item below the > selection. See the attached screenshot. > > 4) Expanding the selection of items in MULTI select mode is currently a bit > weird (due to the changes in the keyboard/arrow key processing), but I > expect you haven't got to that yet. It is probably best to see how other UI > platforms handle this for components similar to GridView > > The 'alternateItemBackgroundColor' style might be useful, but it can always > be added later if/when someone requests it. > > Chris
