[
https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089497#comment-13089497
]
Sandro Martini edited comment on PIVOT-689 at 8/23/11 2:19 PM:
---------------------------------------------------------------
In Theme and TerraTheme, add the ability to load (from json files) even a dark
boolean attribute (and a public method isThemeDark), so skin implementors can
see what to do in case the skin is dark (maybe for the color choosen in the
json file, default false = light skin): for example if the skin in not dark,
use white, otherwise use black, as useful defaults.
Note that in wtk (and even in wtk-terra), there are many defaults where the
color is fixed by code to Color.BLACK or something other ... but with the dark
concept we could at least create a method to get the right color, depending on
it ... and to generalize this concept (maybe in future) we could even calculate
the contrast between two colors, and return one that has enough contrast, just
as useful defaults.
was (Author: smartini):
In Theme and TerraTheme, add the ability to load (from json files) even a
dark boolean attribute (and a public method isThemeDark), so skin implementors
can see what to do in case the skin is dark (maybe for the color choosen in the
json file, default false = light skin): for example if the skin in not dark,
use white, otherwise use black, as useful defaults.
> Finishing touches on Skin Colors
> --------------------------------
>
> Key: PIVOT-689
> URL: https://issues.apache.org/jira/browse/PIVOT-689
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.1
>
> Attachments: PIVOT-689_part1.patch
>
>
> Finishing touches on Skin Colors, some info here (and more later here in
> JIRA): https://issues.apache.org/jira/browse/PIVOT-579
> See if even the final part of this (not implemented) could be useful:
> https://issues.apache.org/jira/browse/PIVOT-245
> And there was another discussion (I have to find where, in nabble) is change
> some color index usage to have better visual appearance (of course
> retrofitting existing behavior when/if possible).
> Note that probably after these little changes, custom color json files should
> be a little updated.
> And a little thing on this:
> now only Tooltips doesn't use a palette color (they use an hard-coded color)
> ... what do you think to make them use the yellow-ish color at
> palette index 19 (or one of is variants, the 18 or 20) ? And use a similar
> (yellow-ish but a different color index, if possible) color on warnings.
> I could adapt a little that color in all Pivot palettes to look similar to
> what should be ... tell me.
> For example, someone remember the background color in Swing Tooltips (ok not
> the best in graphic design and colors :-) ), but with this little change we
> could also have this little feature, where in most palettes will be
> yellow-ish, but where needed could be different.
> Added some documentation in the Terra package JavaDoc file on color palette
> usage in the Terra Skin, to help anyone wants to write their custom colors,
> and then removed, probably the best place for this is in a Tutorial.
> Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some
> Tooltips to see how they happen, but see where they makes sense.
> And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3,
> grouping them by similar components (some componets should be added there).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
