[ 
https://issues.apache.org/jira/browse/PIVOT-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123311#comment-13123311
 ] 

Bill van Melle commented on PIVOT-798:
--------------------------------------

I've attached what I consider the canonical use case for disabling a container, 
a fragment of a fanciful configuration dialog.  The checkboxes control whether 
the things under them are accessible.  In the first case, I disabled the 
container; note that the contents still look clickable.  In the second case, I  
disabled a specific button, and its appearance shows you can't touch it.

I don't think "Add a utility method setEnabledRecursive(boolean)" is a good 
description.  It's more like "Add a way to make a disabled container cause all 
its children to be painted in their disabled style".  In particular, it is 
important that setting enabled to true for the container not suddenly enable 
children that had been disabled before the container was disabled.

Finally, permit me to quibble with the proposal to "keep the current behavior 
as default".  I think it's a bad default.  It violates the principle of "don't 
surprise the user".  If the user can't interact with a portion of the UI, that 
portion shouldn't be painted in a way that invites the user to push buttons, 
click checkboxes, fill in blanks, or whatever.  I realize that, technically, 
changing this behavior of enabled is a backward-incompatible change.  Is there 
any way to assess how many people would be affected?  That is, people who have 
designed a UI in which they disable a container, but do *not* want the 
appearance of the children to change?
                
> Component#isEnabled does not affect appearance recursively
> ----------------------------------------------------------
>
>                 Key: PIVOT-798
>                 URL: https://issues.apache.org/jira/browse/PIVOT-798
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk
>    Affects Versions: 2.0
>            Reporter: Sandro Martini
>             Fix For: 2.1
>
>         Attachments: recursive_disable.bxml
>
>
> Add a utility method setEnabledRecursive(boolean) to the container classes, 
> but keep the current behavior as default.
> Some info here:
> http://apache-pivot-users.399431.n3.nabble.com/Component-isEnabled-does-not-affect-appearance-recursively-td3401718.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to