[ 
https://issues.apache.org/jira/browse/PIVOT-721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roger Whitcomb updated PIVOT-721:
---------------------------------

    Attachment: 721.diff

Here's my proposed fix.
The default behavior remains as it was before the last fix (i.e., "fill" is 
false normally).
If "setFillIcon(true)" is called, then the "fill" is set to "true" and in this 
case the "render" method will then set the image size to the button size, 
allowing the image to both scale up and down to fit the button.
                
> ButtonDataRenderer#setFillIcon has no effect, because its BoxPane doesn't 
> have fill style
> -----------------------------------------------------------------------------------------
>
>                 Key: PIVOT-721
>                 URL: https://issues.apache.org/jira/browse/PIVOT-721
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk
>    Affects Versions: 2.0
>            Reporter: Bill van Melle
>            Assignee: Roger Whitcomb
>            Priority: Minor
>             Fix For: 2.0.3
>
>         Attachments: 721.diff, 
> pivot721_imageview_only_for_debug_DO_NOT_COMMIT.patch
>
>
> ButtonDataRenderer has a setFillIcon method, which supposedly should allow 
> the button's image to be scaled to fit the button.  However, it has no 
> effect, because the renderer is a BoxPane with the default fill=false.
> Fix: In the ButtonDataRenderer constructor, add
>     getStyles().put("fill", true);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to