[ https://issues.apache.org/jira/browse/PIVOT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781663#comment-13781663 ]
Sandro Martini edited comment on PIVOT-916 at 9/30/13 3:59 PM: --------------------------------------------------------------- Hi all, Roger I think too that the final part of the change would break existing applications ... So I'm thinking to resolve this issue now only writing/clarifying JavaDoc with info on how to handle this in 2.0.x (and merge in trunk). Then add a related issue for trunk with breaking changes and add only there ... Work note: verify if update even ScriptApplication to extend Application.Adapter ... and do some test with it, like in the ApplicationHandlerTest . Just put a patch here but still not committed. What do you think ? was (Author: smartini): Hi all, Roger I think too that the final part of the change would break existing applications ... So I'm thinking to resolve this issue now only writing/clarifying JavaDoc with info on how to handle this in 2.0.x (and merge in trunk). Then add a related issue for trunk with breaking changes and add only there ... Work note: verify if update even ScriptApplication to extend Application.Adapter ... and do some test with it, like in the ApplicationHandlerTest . What do you think ? > Replace DesktopApplicationContext.displayException calls with > ApplicationContext.handleUncaughtException > -------------------------------------------------------------------------------------------------------- > > Key: PIVOT-916 > URL: https://issues.apache.org/jira/browse/PIVOT-916 > Project: Pivot > Issue Type: Improvement > Reporter: Karel Hübl > Assignee: Sandro Martini > Fix For: 2.0.4 > > Attachments: ScriptApplication.java.patch, trunk_wtk.patch, > wtk_test.zip > > > There should be consistent way to handle uncaught exceptions in Pivot > applications. > However uncaught exceptions thrown in DesktopApplicationContext class (for > example in application.startup ) are handled using private static method > displayException, which displays dialog and its logic cannot be overriden. > May be ApplicationContext.handleUncaughtException could be made protected and > calls to DesktopApplicationContext.displayException could be replaced by > ApplicationContext.handleUncaughtException. And possibly Application.Adapter > could implement UncaughtExceptionHandler - so current > DesktopApplicationContext.displayException logic could be moved to new > Application.Adapter.uncaughtExceptionThrown method. > This should enable to override uncaught exception handling globally in pivot > applications. > Motivation: > We deploy Pivot app using Java Web Start. Users have by default disabled Java > Console (and they are not familiar with it). We want to display custom dialog > to handle uncaught exceptions displaying full stack trace and with possiblity > to report exception to help desk. > I think, in current implementation it is not possible to override handling of > uncaught exceptions thrown during application init and other specific > situations. -- This message was sent by Atlassian JIRA (v6.1#6144)