[
https://issues.apache.org/jira/browse/PIVOT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782020#comment-13782020
]
Roger Whitcomb commented on PIVOT-916:
--------------------------------------
I think we should set the display variable in the Application BEFORE calling
the startup method instead of making "startup" do it, and requiring all
implementations of Application.Adapter change their constructors to do
"super(...)". There are only two places that actually call the "startup"
method, which are in BrowserApplicationContext.java and
DesktopApplicationContext.java. It would be a simple matter in these places,
before calling "startup" to set the display in the application object (maybe
need a new "setDisplay" method?), and then the Application.Adapter doesn't need
to do it, nor do any user applications need to change.
I will post a patch for this shortly....
> Replace DesktopApplicationContext.displayException calls with
> ApplicationContext.handleUncaughtException
> --------------------------------------------------------------------------------------------------------
>
> Key: PIVOT-916
> URL: https://issues.apache.org/jira/browse/PIVOT-916
> Project: Pivot
> Issue Type: Improvement
> Reporter: Karel Hübl
> Assignee: Sandro Martini
> Fix For: 2.0.4
>
> Attachments: ScriptApplication.java.patch, trunk_wtk.patch,
> wtk_test.zip
>
>
> There should be consistent way to handle uncaught exceptions in Pivot
> applications.
> However uncaught exceptions thrown in DesktopApplicationContext class (for
> example in application.startup ) are handled using private static method
> displayException, which displays dialog and its logic cannot be overriden.
> May be ApplicationContext.handleUncaughtException could be made protected and
> calls to DesktopApplicationContext.displayException could be replaced by
> ApplicationContext.handleUncaughtException. And possibly Application.Adapter
> could implement UncaughtExceptionHandler - so current
> DesktopApplicationContext.displayException logic could be moved to new
> Application.Adapter.uncaughtExceptionThrown method.
> This should enable to override uncaught exception handling globally in pivot
> applications.
> Motivation:
> We deploy Pivot app using Java Web Start. Users have by default disabled Java
> Console (and they are not familiar with it). We want to display custom dialog
> to handle uncaught exceptions displaying full stack trace and with possiblity
> to report exception to help desk.
> I think, in current implementation it is not possible to override handling of
> uncaught exceptions thrown during application init and other specific
> situations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
