[
https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815778#comment-13815778
]
Sandro Martini commented on PIVOT-689:
--------------------------------------
Made some minor changes to a color in TerraTheme_dark.json, to better contrast
with Text color, so Text in tooltips is readable now.
Note that for example running ColorSchemeBuilder with that color scheme
definition ( org.apache.pivot.demos.styles.ColorSchemeBuilder
-Dorg.apache.pivot.wtk.skin.terra.location=TerraTheme_dark.json )
I see some minor visual inconsistencies:
- mouse over some component doesn't brighten the row/element (when themeIsDark
is true sould be used the negative effect on colors, and usually this is
darkening the element when themeIsDark is false)
- mouse over Menu Button hilite elements but with a different color (and
probably even Menu, I have to check this in other test applications) ... but
this could be right because on a Menu when I select something the menu
disappears
- the tree have a white background which is not consistent with color scheme
used ... but could be a problem in the scroll area instead, I have to check
- maybe others, please tell me if someone finds something
In attach I put a sample eclipse launch config file, to simplify tests.
Last, an interesting feature could be to give a Theme the ability to return a
list of Components (and related class names) registered in it ... if useful I
could add to the Theme, please tell me if useful/needed.
Comments ?
> Finishing touches on Skin Colors
> --------------------------------
>
> Key: PIVOT-689
> URL: https://issues.apache.org/jira/browse/PIVOT-689
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Priority: Minor
> Fix For: 2.1
>
> Attachments: pivot689.patch
>
>
> Finishing touches on Skin Colors, some info here (and more later here in
> JIRA): https://issues.apache.org/jira/browse/PIVOT-579
> See if even the final part of this (not implemented) could be useful:
> https://issues.apache.org/jira/browse/PIVOT-245
> And there was another discussion (I have to find where, in nabble) is change
> some color index usage to have better visual appearance (of course
> retrofitting existing behavior when/if possible).
> Note that probably after these little changes, custom color json files should
> be a little updated.
> And a little thing on this:
> now only Tooltips doesn't use a palette color (they use an hard-coded color)
> ... what do you think to make them use the yellow-ish color at
> palette index 19 (or one of is variants, the 18 or 20) ? And use a similar
> (yellow-ish but a different color index, if possible) color on warnings.
> I could adapt a little that color in all Pivot palettes to look similar to
> what should be ... tell me.
> For example, someone remember the background color in Swing Tooltips (ok not
> the best in graphic design and colors :-) ), but with this little change we
> could also have this little feature, where in most palettes will be
> yellow-ish, but where needed could be different.
> Added some documentation in the Terra package JavaDoc file on color palette
> usage in the Terra Skin, to help anyone wants to write their custom colors,
> and then removed, probably the best place for this is in a Tutorial.
> Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some
> Tooltips to see how they happen, but see where they makes sense.
> And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3,
> grouping them by similar components (some componets should be added there).
--
This message was sent by Atlassian JIRA
(v6.1#6144)
