[
https://issues.apache.org/jira/browse/PIVOT-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851130#comment-13851130
]
Roger Whitcomb commented on PIVOT-932:
--------------------------------------
I reworked the patch a little bit (renamed the variable, moved it higher up and
reversed the suppression logic), but essentially the same result. I just
thought the variable could be more explicit as to what was actually happening.
branches/2.0.x:
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraFileBrowserSkin.java
Transmitting file data .
Committed revision 1551768.
trunk:
Sending .
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraFileBrowserSkin.java
Transmitting file data .
Committed revision 1551771.
> FileBrowser 'setRootDirectory' method bug with > 1 drive
> --------------------------------------------------------
>
> Key: PIVOT-932
> URL: https://issues.apache.org/jira/browse/PIVOT-932
> Project: Pivot
> Issue Type: Bug
> Environment: Windows. Used daemon tools lite to simulate multiple
> drives.
> Reporter: Oliver Oyston
> Priority: Minor
> Attachments: TerraFileBrowserSkin.java.patch
>
>
> The FileBrowser 'setRootDirectory' method does not correctly work if more
> than one drive is present and the chosen root directory is on a drive other
> than the first logical drive.
> The problem appears to be in the following class:
> org.apache.pivot.wtk.skin.terra.TerraFileBrowserSkin
> The code is a bit hard to follow, but I think the problem is that the drive
> list button item is set in the "rootDirectoryChanged" method of the skin:
> driveListButton.setSelectedItem(drive);
> and this leads to setRootDirectory being called again for the root of the
> drive. Typically you want this to happen, but not when a root directory is in
> the process of being set.
> The bug manifests itself as the correct path being displayed in the file
> browser, but the files list is that of the root of the drive.
> I have a proposed fix that seems to work.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
