[ 
https://issues.apache.org/jira/browse/PIVOT-933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roger Whitcomb updated PIVOT-933:
---------------------------------

    Attachment: branch.patch

The "branch.patch" file is the diff for the basic changes to add the two 
methods to TreeViewBranchListener and its Adapter subclass, and to actually do 
the vote processing.  It also adds the methods to the TerraTreeViewSkin (which 
are currently no-ops).  Everything builds and the Javadoc is clean.  I will try 
it in our application before committing the changes.

> Allow refusal to open a TreeView branch
> ---------------------------------------
>
>                 Key: PIVOT-933
>                 URL: https://issues.apache.org/jira/browse/PIVOT-933
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk, wtk-terra
>    Affects Versions: 2.1
>         Environment: All
>            Reporter: Roger Whitcomb
>            Assignee: Roger Whitcomb
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: branch.patch
>
>
> In some cases (i.e., doing lazy loading of contents of a tree branch) an 
> error might occur that precludes getting the information for the branch.  In 
> this case it would be better to simply refuse to open the branch because the 
> information is inaccurate or not available, rather than show a (potentially 
> misleading) empty list.
> This is a simple change to add a method to TreeViewBranchListener called 
> "previewBranchExpandedChange" that returns a Vote as to whether or not to 
> expand/collapse the branch, similarly to the way Rollups and Accordions work. 
>  The Adapter will return Vote.APPROVE so (most) existing apps will continue 
> to work as before (unless they directly implement the TreeViewBranchListener 
> interface instead of subclassing the Adapter).  Will also need to implement 
> the "branchExpandedChangeVetoed" method to be consistent (although there is 
> currently no use for it in the skin).
> Adding this in a point release (2.1) instead of a maintenance release (2.0.4) 
> because the API is changing.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to