[
https://issues.apache.org/jira/browse/PIVOT-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995028#comment-13995028
]
Sandro Martini commented on PIVOT-948:
--------------------------------------
Hi Roger, after a quick look at the patch I think it's good. My only concern is
on:
> The logic is changed as follows:
I'm sure now it's better, but are we sure it's good even this small *change*
for 2.0.x ?
Anyway, for including it in 2.0.4 I have no problem, but we have to:
- merge to branches/2.0.x, and make some test
- stop (cancel) the current vote
- delete the 2.0.4 tag
- regenerate the release candicate (with a new tag) and redeploy artifacts for
the vote
- start a new vote.
Note only that before next week I won't have so much free time (approx. 3 / 4
hours for all steps), sorry ... or we could fix it for 2.0.5 :-) . Tell me what
you think. Bye
> Allow selected key bindings to work with unselected items
> ---------------------------------------------------------
>
> Key: PIVOT-948
> URL: https://issues.apache.org/jira/browse/PIVOT-948
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0.3
> Environment: All
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Labels: binding
> Fix For: 2.1
>
> Attachments: binding.patch
>
>
> If you set a selected key binding (on a ListButton, ListView, TableView or
> Spinner), and invoke the "store" method when no item is selected, you can get
> an error about not being able to assign "null" to an "int" field (in my case).
> The problem is that "store" tests for nothing being selected and sets the
> item to null without even calling the binding method. In my case, I am using
> the binding to just store the selected index as an integer, so the item will
> not end up being null, except that the binding method is never called.
> So, the item value to be stored should be left up to the binding method, even
> in the "unselected" case in order to be consistent (and to allow my selected
> index bind mapping to work correctly, even in the unselected case).
> It will be more clear what the problem is when you see the patch file.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
