[ 
https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073065#comment-14073065
 ] 

Sandro Martini edited comment on PIVOT-689 at 7/24/14 10:36 AM:
----------------------------------------------------------------

Just committed (but only in trunk) in rev. 1613063 a small fix that make 
Tooltips use the same palette color for the border (like in all other 
components), before it was using always Black.
Note that if for tooltips otherwise I suggest the usage of another palette 
color, that used for Labels.

Tell me if this small part of the fix is needed even in 2.0.x .

> corner isn't part of the header - it is drawn by the ScrollPane
So could be too much complex to fix (in a generic way, because ScrollPanes are 
used in many components), so this won't be fixed, sorry.

Unless objections I'll mark this as resolved in a few days.



was (Author: smartini):
Just committed (but only in trunk) in rev. 1613063 a small fix that make 
Tooltips use the same palette color for the border (like in all other 
components), before it was using always Black.
Note that if for tooltips otherwise I suggest the usage of another palette 
color, that used for Labels.

Tell me if this small part of the fix is needed even in 2.0.x .

Unless objections I'll mark this as resolved in a few days.


> Finishing touches on Skin Colors
> --------------------------------
>
>                 Key: PIVOT-689
>                 URL: https://issues.apache.org/jira/browse/PIVOT-689
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk-terra
>            Reporter: Sandro Martini
>            Assignee: Sandro Martini
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: ColorSchemeBuilder - dark.launch, KitchenSink - 
> Dark.launch, pivot689.patch
>
>
> Finishing touches on Skin Colors, some info here (and  more later here in 
> JIRA): https://issues.apache.org/jira/browse/PIVOT-579
> See if even the final part of this (not implemented) could be useful: 
> https://issues.apache.org/jira/browse/PIVOT-245
> And there was another discussion (I have to find where, in nabble) is change 
> some color index usage to have better visual appearance (of course 
> retrofitting existing behavior when/if possible).
> Note that probably after these little changes, custom color json files should 
> be a little updated.
> And a little thing on this:
> now only Tooltips doesn't use a palette color (they use an hard-coded color) 
> ... what do you think to make them use the yellow-ish color at
> palette index 19 (or one of is variants, the 18 or 20) ? And use a similar 
> (yellow-ish but a different color index, if possible) color on warnings.
> I could adapt a little that color in all Pivot palettes to look similar to 
> what should be ... tell me.
> For example, someone remember the background color in Swing Tooltips (ok not 
> the best in graphic design and colors :-) ), but with this little change we 
> could also have this little feature, where in most palettes will be 
> yellow-ish, but where needed could be different.
> Added some documentation in the Terra package JavaDoc file on color palette 
> usage in the Terra Skin, to help anyone wants to write their custom colors, 
> and then removed, probably the best place for this is in a Tutorial.
> Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some 
> Tooltips to see how they happen, but see where they makes sense.
> And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3, 
> grouping them by similar components (some componets should be added there).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to