[
https://issues.apache.org/jira/browse/PIVOT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129780#comment-14129780
]
Sandro Martini edited comment on PIVOT-689 at 9/11/14 10:12 AM:
----------------------------------------------------------------
> TextArea now has a light gray background that also used to be white
perhaps I forget some changes here (and even in TextPane), I agree that white
background is better, and they must be consistent with TextInput
=> Committed the fix in revision 1624221.
> Menu items now have a light gray background that used to be transparent or
> white
this should be more consistent with other components (even on the transparency)
...
=> after some check I confirm that things are consistent (more than before)
with other components, at least running ColorSchemeBuilder, ComponentExplorer,
Kitchen Sink; the light gray background is the same used in other backgrounds
(I think should be a good default, even because it makes a little visual
difference from the white area at left in any menu item)
=> do you need/prefer white even for menu item elements ? or is no more
possible to override this value (didn't tried, just guessing) ?
was (Author: smartini):
> TextArea now has a light gray background that also used to be white
perhaps I forget some changes here (and even in TextPane), I agree that white
background is better, and they must be consistent with TextInput
=> Committed the fix in revision 1624221.
> Menu items now have a light gray background that used to be transparent or
> white
this should be more consistent with other components (even on the transparency)
... otherwise we could use here the same background color used in TextInput
(but interface could be too much whitening) ... anyway we can try, ok ?
=> I have to make some check on this ...
thanks for catching this
> Finishing touches on Skin Colors
> --------------------------------
>
> Key: PIVOT-689
> URL: https://issues.apache.org/jira/browse/PIVOT-689
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Reporter: Sandro Martini
> Assignee: Sandro Martini
> Fix For: 2.1, 2.0.5
>
> Attachments: ColorSchemeBuilder - dark.launch, ComponentExplorer -
> dark.launch, KitchenSink - Dark.launch, pivot689.patch,
> pivot_colorschemebuilder_dark_flat_screencapt.png,
> pivot_colorschemebuilder_dark_screencapt.png,
> pivot_colorschemebuilder_default_flat_screenshot.png,
> pivot_colorschemebuilder_default_screencapt.png
>
>
> Finishing touches on Skin Colors, some info here (and more later here in
> JIRA): https://issues.apache.org/jira/browse/PIVOT-579
> See if even the final part of this (not implemented) could be useful:
> https://issues.apache.org/jira/browse/PIVOT-245
> And there was another discussion (I have to find where, in nabble) is change
> some color index usage to have better visual appearance (of course
> retrofitting existing behavior when/if possible).
> Note that probably after these little changes, custom color json files should
> be a little updated.
> And a little thing on this:
> now only Tooltips doesn't use a palette color (they use an hard-coded color)
> ... what do you think to make them use the yellow-ish color at
> palette index 19 (or one of is variants, the 18 or 20) ? And use a similar
> (yellow-ish but a different color index, if possible) color on warnings.
> I could adapt a little that color in all Pivot palettes to look similar to
> what should be ... tell me.
> For example, someone remember the background color in Swing Tooltips (ok not
> the best in graphic design and colors :-) ), but with this little change we
> could also have this little feature, where in most palettes will be
> yellow-ish, but where needed could be different.
> Added some documentation in the Terra package JavaDoc file on color palette
> usage in the Terra Skin, to help anyone wants to write their custom colors,
> and then removed, probably the best place for this is in a Tutorial.
> Last, in ColorSchemeBuilder (and maybe even in the Kitchen Sink), add some
> Tooltips to see how they happen, but see where they makes sense.
> And maybe in ColorSchemeBuilder move some elements in the Tab2 or Tab3,
> grouping them by similar components (some componets should be added there).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
