[
https://issues.apache.org/jira/browse/PIVOT-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167527#comment-14167527
]
Roger Whitcomb commented on PIVOT-959:
--------------------------------------
In looking through the code, it seems like TerraTextInputSkin is the only class
that does this (call "super.keyPressed" twice). The "consumed" value from the
first call is never used, and in fact, is set by each of the "if" cases, and
"else" sets it by calling "super.keyPressed" again. So, I agree with
Alessandro's analysis, and believe that we should take out the first call.
If there would be problems it would be with the keys that are processed in this
skin method itself (which would be DELETE, BACKSPACE, HOME, END, arrow keys,
etc.). The only problem I could envision would be with TAB (which should
traverse fields in a container) but which is never processed by TextInput. So,
I believe this fix would be completely safe.
> TerraTextInputSkin may process the same key press twice
> -------------------------------------------------------
>
> Key: PIVOT-959
> URL: https://issues.apache.org/jira/browse/PIVOT-959
> Project: Pivot
> Issue Type: Bug
> Components: wtk-terra
> Affects Versions: 2.0.4
> Reporter: Alessandro Pira
> Priority: Minor
> Fix For: 2.1, 2.0.5
>
>
> TerraTextInputSkin's keyPress method may call super.keyPress twice (once as
> its first instruction, and then again in the "else" branch).
> I suggest to remove the first ancestor call.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
