[
https://issues.apache.org/jira/browse/PIVOT-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590947#comment-16590947
]
Roger Whitcomb commented on PIVOT-1041:
---------------------------------------
Put the constant values I could find right away into the Constants class:
Sending core\src\org\apache\pivot\io\FileSerializer.java
Sending core\src\org\apache\pivot\json\JSONSerializer.java
Sending core\src\org\apache\pivot\serialization\ByteArraySerializer.java
Sending core\src\org\apache\pivot\serialization\CSVSerializer.java
Sending core\src\org\apache\pivot\serialization\StringSerializer.java
Adding core\src\org\apache\pivot\util\Constants.java
Sending core\src\org\apache\pivot\util\Resources.java
Sending core\src\org\apache\pivot\util\Service.java
Sending core\src\org\apache\pivot\xml\XMLSerializer.java
Sending demos\src\org\apache\pivot\demos\suggest\SuggestionDemo.java
Sending web\src\org\apache\pivot\web\Query.java
Sending web-server\src\org\apache\pivot\web\server\QueryServlet.java
Sending wtk\src\org\apache\pivot\wtk\BrowserApplicationContext.java
Sending wtk\src\org\apache\pivot\wtk\text\PlainTextSerializer.java
Transmitting file data ..............done
Committing transaction...
Committed revision 1838770.
> Add a Constants class as a place to store frequently used constant values
> -------------------------------------------------------------------------
>
> Key: PIVOT-1041
> URL: https://issues.apache.org/jira/browse/PIVOT-1041
> Project: Pivot
> Issue Type: Improvement
> Components: core-util
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
>
> There are a number of strings and other constant (usually static final)
> values that are scattered in multiple places, but with the same values.
> These could meaningfully be put into a single place and referenced from there.
> Examples include:
> * int BUFFER_SIZE = 16384 (for BufferedReader, Writer)
> * String HTTP_PROTOCOL, String HTTPS_PROTOCOL
> * "UTF-8" or the UTF_8 charset
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
