[
https://issues.apache.org/jira/browse/PIVOT-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905653#comment-16905653
]
Roger Whitcomb commented on PIVOT-1046:
---------------------------------------
Basically finished this issue:
Sending
tutorials\src\org\apache\pivot\tutorials\bxmlexplorer\FakeWindowSkin.java
Sending
tutorials\src\org\apache\pivot\tutorials\databinding\PropertyBinding.java
Sending wtk\src\org\apache\pivot\wtk\CSSColor.java
Sending wtk\src\org\apache\pivot\wtk\content\ColorItem.java
Sending wtk\src\org\apache\pivot\wtk\content\ListButtonColorItemRenderer.java
Sending wtk\src\org\apache\pivot\wtk\content\ListViewColorItemRenderer.java
Sending wtk\src\org\apache\pivot\wtk\util\ColorUtilities.java
Sending wtk\test\org\apache\pivot\wtk\test\ColorUtilitiesTest.java
Sending
wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraActivityIndicatorSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraAlertSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraCheckboxSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraDialogSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraFrameSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraMenuSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraPaletteSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraRadioButtonSkin.java
Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraSheetSkin.java
Transmitting file data .................done
Committing transaction...
Committed revision 1864994.
> Regularize ColorUtilities methods
> ---------------------------------
>
> Key: PIVOT-1046
> URL: https://issues.apache.org/jira/browse/PIVOT-1046
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
>
> The method names in ColorUtilities are a bit verbose, and not regular (in
> that there is a method to add transparency, but not one to take it away).
> I propose to deprecate "setTransparencyInColor" and add "toTransparentColor"
> which does the same thing with a "better" name. Then propose adding
> "toSolidColor" as the obverse. This will regularize the functions in here
> better, while still leaving the old method (deprecated) for backward
> compatibility.
> Next step would be changing all the callers to use the new method(s).
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
