Here’s some things I found: * The <br/> were needed to eliminate errors in some versions, but that may have been eliminated by some other switches, or something. Let me fix those … * The entity code errors can be ignored … * I will look into the VersionTest failing .. it works fine on my machine … not sure what’s wrong. * I don’t think JDK-17 will work — the Applet classes are gone, so I don’t think it builds even with -version 8 (since JDK-14), JDK-11 is the latest I’ve been able to use to build with * BTW latest LTS release is JDK-21 (not 17) * I’m still working on the RELEASE-NOTES — it’s a long process: 777 commits, 96 issues mentioned, 313 other commits with no issue
I’ll catch up. ~Roger > On Nov 17, 2023, at 10:47 AM, Sandro Martini <sandro.mart...@gmail.com > <mailto:sandro.mart...@gmail.com>> wrote: > > Hi all, > an update on my test for preparing the 2.1.0 release: > - setup of a build vm on Ubuntu 22.04.x and OpenJDK 11 and all related > dependencies: done > - fix svn permissions on files (to repeat often before final release): done > (at the moment) > - RAT analysis on sources: done, all seems fine (there are files without > the Apache license but are usual Eclipse-related project files or txt files > for samples, etc) > - build of sources: done, with source 1.8, target 1.8 ... but I see the > following errors running `ant build` (ant 1.10.14): > ``` > ... > [javadoc] Building tree for all the packages and classes... > [javadoc] > /home/sandro/work/pivot/pivot-trunk/core/src/org/apache/pivot/serialization/BinarySerializer.java:30: > error: self-closing element not allowed > [javadoc] * hierarchy are required to implement {@link > java.io.Serializable}.<br/> > [javadoc] > ^ > [javadoc] > /home/sandro/work/pivot/pivot-trunk/web-server/src/org/apache/pivot/web/server/QueryServlet.java:47: > error: self-closing element not allowed > [javadoc] * Abstract base class for query servlets.<br/> > [javadoc] ^ > [javadoc] > /home/sandro/work/pivot/pivot-trunk/wtk/src/org/apache/pivot/wtk/Keyboard.java:265: > error: invalid entity ⌃ > [javadoc] * using "-" separator), > <code>⌃⇧Right</code> (OSX-style modifiers without separator), > [javadoc] ^ > [javadoc] > /home/sandro/work/pivot/pivot-trunk/wtk/src/org/apache/pivot/wtk/Keyboard.java:265: > error: invalid entity ⇧ > [javadoc] * using "-" separator), > <code>⌃⇧Right</code> (OSX-style modifiers without separator), > [javadoc] ^ > [javadoc] > /home/sandro/work/pivot/pivot-trunk/wtk/src/org/apache/pivot/wtk/Keyboard.java:266: > error: invalid entity ⌥ > [javadoc] * <code>⌥-⇧-F4</code> (OSX-style with > separators), or <code>ALT+ctrl+R</code> (upper- or > [javadoc] ^ > [javadoc] > /home/sandro/work/pivot/pivot-trunk/wtk/src/org/apache/pivot/wtk/Keyboard.java:266: > error: invalid entity ⇧ > [javadoc] * <code>⌥-⇧-F4</code> (OSX-style with > separators), or <code>ALT+ctrl+R</code> (upper- or > [javadoc] ^ > [javadoc] > /home/sandro/work/pivot/pivot-trunk/wtk/src/org/apache/pivot/wtk/Keyboard.java:339: > error: invalid entity ⌃ > [javadoc] * {@code "Ctrl+Shift+Left"}, or even > <code>"⌃⌘F1"</code>. > [javadoc] > ^ > [javadoc] > /home/sandro/work/pivot/pivot-trunk/wtk/src/org/apache/pivot/wtk/Keyboard.java:339: > error: invalid entity ⌘ > [javadoc] * {@code "Ctrl+Shift+Left"}, or even > <code>"⌃⌘F1"</code>. > [javadoc] > ^ > ... > test: > [echo] charts: Executing test cases... > [echo] core: Executing test cases... > [junit] Test org.apache.pivot.util.test.VersionTest FAILED > ... > > BUILD FAILED > /home/sandro/work/pivot/pivot-trunk/build.xml:581: Error: One or more tests > failed! > ``` > -- so there is something to fix in the code, at least the failing > test: @Roger > Whitcomb <rwhitc...@apache.org <mailto:rwhitc...@apache.org>> would you be > able to help on that ? Thanks > a lot. > - PGP signature for release: TODO (Sandro) > - update RELEASE-NOTES with the updated list of issues completed in this > release: TODO (Roger, Sandro) > - other ? > > Note that I'm using the latest OpenJDK-11, but once all has been fixed, do > you think it would be better to use the latest OpenJDK-17 instead ? > > Just for info I'm following the guideline found at: > https://urldefense.proofpoint.com/v2/url?u=http-3A__svn.apache.org_repos_asf_pivot_infra_CREATE-5FRELEASE-5FWORKFLOW&d=DwIFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=NGXYnxeSiI_cX848yMIhm_nxVirU2qvwSBiomy8msDM&m=u57u_sL05bQ2vlsAlm1CaEU2MnDsd3YV9Lp_BLVTsoSAgzMhqYF6yRR-ZnDtehaQ&s=W1_Nw0mIJ7JkXKIy7QrihpiLrEtbJV2qD-5uwKm4tLg&e= > > <https://urldefense.proofpoint.com/v2/url?u=http-3A__svn.apache.org_repos_asf_pivot_infra_CREATE-5FRELEASE-5FWORKFLOW&d=DwIFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=NGXYnxeSiI_cX848yMIhm_nxVirU2qvwSBiomy8msDM&m=u57u_sL05bQ2vlsAlm1CaEU2MnDsd3YV9Lp_BLVTsoSAgzMhqYF6yRR-ZnDtehaQ&s=W1_Nw0mIJ7JkXKIy7QrihpiLrEtbJV2qD-5uwKm4tLg&e=> > . > > Hope it's good, sorry for the so long time taken but we are proceeding. > > Let's update. > Bye > > > Il giorno mer 1 nov 2023 alle ore 03:32 Roger Whitcomb < > rogerandb...@rbwhitcomb.com <mailto:rogerandb...@rbwhitcomb.com>> ha scritto: > >> Ciao Sandro, >> I will help with all these that I can. Please note I committed one more >> set of changes that I’ve had pending for upwards of a year (so, well tested >> at least). >> >> And yes, I’d say Java 8 is still “required” in that there is nothing in >> the code that can’t be run in Java 8, and so it is still compatible as far >> back as Oracle is still supporting (that is, Java 6 which was the previous >> requirement is no longer supported). AFAICT Java 8 vs Java 11 is no big >> deal, as in no particular reason to require java 11, when Java 11 runs Java >> 8 code just fine. >> >> There are still some svn: properties inconsistencies (in that there are >> still some DOS-style line endings in some files). >> >> Yes, I think Junit 4.x should still work (i’m using 4.11 on my MacBook). >> >> List of JIRA issues and changes will be HARD because it has been SO LONG >> and I’ve made literally 100s of changes since. But I will do my best, but >> it will probably take about a week … >> >> Thanks SO MUCH, >> ~Roger >> >>> On Oct 31, 2023, at 12:17 PM, Sandro Martini >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__sandro.martini-40gmail.com&d=DwIFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=NGXYnxeSiI_cX848yMIhm_nxVirU2qvwSBiomy8msDM&m=u57u_sL05bQ2vlsAlm1CaEU2MnDsd3YV9Lp_BLVTsoSAgzMhqYF6yRR-ZnDtehaQ&s=4pnRisr65Osx2doRWmy2_JBdM11KOpTAUBQsikfqeEs&e= >>> >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__sandro.martini-40gmail.com&d=DwIFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=NGXYnxeSiI_cX848yMIhm_nxVirU2qvwSBiomy8msDM&m=u57u_sL05bQ2vlsAlm1CaEU2MnDsd3YV9Lp_BLVTsoSAgzMhqYF6yRR-ZnDtehaQ&s=4pnRisr65Osx2doRWmy2_JBdM11KOpTAUBQsikfqeEs&e=>> >> wrote: >>> >>> Hi all, >>> I'm still doing the setup of the vm for the release build, looking at >> docs >>> (see it here >>> < >> https://urldefense.proofpoint.com/v2/url?u=http-3A__svn.apache.org_repos_asf_pivot_infra_CREATE-5FRELEASE-5FWORKFLOW&d=DwIFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=NGXYnxeSiI_cX848yMIhm_nxVirU2qvwSBiomy8msDM&m=_EirRUz7n8yN5YBagiAtTLU38b9mnJS7wxfUd_9mAMGeGVltCnfvHCmymsqNKWO9&s=a7yHbKSZmYORo1MktnNVjEdzlIPnWGd7AGkg5pYQq5E&e= >> >> <https://urldefense.proofpoint.com/v2/url?u=http-3A__svn.apache.org_repos_asf_pivot_infra_CREATE-5FRELEASE-5FWORKFLOW&d=DwIFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=NGXYnxeSiI_cX848yMIhm_nxVirU2qvwSBiomy8msDM&m=_EirRUz7n8yN5YBagiAtTLU38b9mnJS7wxfUd_9mAMGeGVltCnfvHCmymsqNKWO9&s=a7yHbKSZmYORo1MktnNVjEdzlIPnWGd7AGkg5pYQq5E&e=>>) >> it >>> seems that there are some open points: >>> - which JUnit version to use (latest 4.x is good) ? >>> - we need to gather the whole list of JIRA issues done for this release >> and >>> put a summary in the README, grouped per type; then commit the updated >> file >>> - compatibility with Java 8 is really required ? >>> - svn properties fixed for all committed files -> I'm working on it (and >>> other checks are needed for release content, see related scripts); >>> something just committed, but expect other to be committed (there are >> some >>> other files that need a fix in svn properties); please check that my >> commit >>> didn't broke something (it shouldn't) >>> - release files have to be signed with my PGP signature, I need to >> further >>> check details >>> and lastly I need to refresh my memory about other related stuff, sorry >> but >>> I created the previous release years ago. >>> >>> FYI final release artifacts (once release will be approved) will be >> pushed >>> into the new distribution folder, which is here >>> < >> https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_release_pivot_&d=DwIFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=NGXYnxeSiI_cX848yMIhm_nxVirU2qvwSBiomy8msDM&m=_EirRUz7n8yN5YBagiAtTLU38b9mnJS7wxfUd_9mAMGeGVltCnfvHCmymsqNKWO9&s=CDteuPRaQp-71krYJ6hb4tGUh1hCr7UIcfZbOPkHCcM&e= >> >> <https://urldefense.proofpoint.com/v2/url?u=https-3A__dist.apache.org_repos_dist_release_pivot_&d=DwIFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=NGXYnxeSiI_cX848yMIhm_nxVirU2qvwSBiomy8msDM&m=_EirRUz7n8yN5YBagiAtTLU38b9mnJS7wxfUd_9mAMGeGVltCnfvHCmymsqNKWO9&s=CDteuPRaQp-71krYJ6hb4tGUh1hCr7UIcfZbOPkHCcM&e=>>; >> then generated jar >>> artifacts will be published even to Maven Central (I can do it later). >>> >>> @Roger could you help me with these questions ? About JIRA issues, you >>> think that a filter between releases could be good the same (probably >> we'll >>> need to check the list of issues) >>> >>> Let's update during the next few days ... >>> >>> Thanks a lot. >>> Bye >>> >>> >>> >>> >>> Il giorno mar 31 ott 2023 alle ore 12:09 Sandro Martini < >> https://urldefense.proofpoint.com/v2/url?u=http-3A__sandro.martini-40gmail.com&d=DwIFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=NGXYnxeSiI_cX848yMIhm_nxVirU2qvwSBiomy8msDM&m=_EirRUz7n8yN5YBagiAtTLU38b9mnJS7wxfUd_9mAMGeGVltCnfvHCmymsqNKWO9&s=Pa8A7duU2ELZt8SOvRI_R8WB-1EY7A2NbkwL3zH1sVk&e= >> >> <https://urldefense.proofpoint.com/v2/url?u=http-3A__sandro.martini-40gmail.com&d=DwIFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=NGXYnxeSiI_cX848yMIhm_nxVirU2qvwSBiomy8msDM&m=_EirRUz7n8yN5YBagiAtTLU38b9mnJS7wxfUd_9mAMGeGVltCnfvHCmymsqNKWO9&s=Pa8A7duU2ELZt8SOvRI_R8WB-1EY7A2NbkwL3zH1sVk&e=>> >> ha scritto: >>> >>>> Hi all, >>>> sure I'm available for this last release. >>>> I only need some time for the setup of a new vm for the build >> environment >>>> based on a modern Linux distribution and JDK 11 and all the stuff for >> the >>>> creation and testing of the release. >>>> >>>> For 2.1.0 really do we need compatibility with Java 8 ? >>>> Just to be sure if the compatibility flag has to be enabled in >> compilation >>>> ... >>>> >>>> Tell me. >>>> >>>> Thanks. >>>> Bye >>>> >>>> >>>> >>>> Il giorno lun 30 ott 2023 alle ore 17:33 Roger Whitcomb < >>>> roger.whitco...@gmail.com <mailto:roger.whitco...@gmail.com>> ha scritto: >>>> >>>>> Hi all, >>>>> In (partial) response to Craig’s call for a vote on sunsetting the >> Pivot >>>>> project, I (still) want to do a final release to ensure that all the >> latest >>>>> changes are publicly available before moving to the Attic. Since >> Sandro has >>>>> done all the latest releases, I’m hoping that he is available to do >> this >>>>> release. Presumably we would need Java 11 installed to build for Java 8 >>>>> (and including applet support which is missing in later Java releases). >>>>> >>>>> I am in the process of committing all my latest changes so we have >>>>> everything I have done in the repository. >>>>> >>>>> Sandro, let me know .. >>>>> >>>>> Thanks, >>>>> ~Roger Whitcomb
