On the topic of coverage…

The way the “integrations” are setup, they aren’t inheriting the “Fail the 
build” config setup in plc4j/pom.xml.
Is that intentional?  Should that config be pushed up into the top level pom, 
or duplicated in integrations/pom.xml (or individual integrations)?

Also it would be helpful if DEVELOPMENT.md were updated to capture the “how to 
run sonar locally” info below.

Thanks!
— Dale

> On Jan 6, 2018, at 12:32 PM, Christofer Dutz <[email protected]> 
> wrote:
> 
> Hi Justin,
> 
> well I just installed and started a local sonarqube server and executed this:
> 
> clean install sonar:sonar -Dsonar.host.url=http://localhost:9000/
> 
> And it worked file.
> 
> Chris
> 
> Am 06.01.18, 01:24 schrieb "Justin Mclean" <[email protected]>:
> 
>    Hi,
> 
>    I've see you changed it so that running locally no longer works and it’s 
> publishing to Apache builds.
> 
>    That’s great but how would I test my changes and run sonar locally before 
> having to commit changes?
> 
>    Thanks,
>    Justin
> 

Reply via email to