dlaboss commented on a change in pull request #8: cleanup warnings in
plc4j-api, plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170931306
##########
File path:
plc4j/core/src/test/java/org/apache/plc4x/java/PlcDriverManagerTest.java
##########
@@ -26,21 +37,11 @@ Licensed to the Apache Software Foundation (ASF) under one
import org.junit.Test;
import org.junit.experimental.categories.Category;
-import java.io.File;
-import java.net.MalformedURLException;
-import java.net.URL;
-import java.net.URLClassLoader;
-
-import static org.hamcrest.core.Is.is;
-import static org.hamcrest.core.IsInstanceOf.instanceOf;
-import static org.hamcrest.core.IsNull.notNullValue;
-import static org.hamcrest.core.IsNull.nullValue;
-import static org.junit.Assert.assertThat;
-
public class PlcDriverManagerTest {
/**
* Tries to get the mock plc driver which is part of this testsuite.
+ * @throws PlcException
Review comment:
I can make that transformation if that's the policy the team wants. Anyone
want to toss in a +1 on that? (another policy to document in a DEVELOPMENT.md)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
