chrisdutz commented on a change in pull request #9: Added some javadoc to S7
communication path and several todos that ma…
URL: https://github.com/apache/incubator-plc4x/pull/9#discussion_r207142023
##########
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/items/ReadRequestItem.java
##########
@@ -52,6 +64,8 @@ public boolean equals(Object o) {
return false;
}
ReadRequestItem<?> that = (ReadRequestItem<?>) o;
+ // TODO 01.18.18 jf: we should also call the comparison of super at
least otherwise this can lead to unwanted behavior.
Review comment:
Aren't we doing exactly this super check 4 lines above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
