chrisdutz commented on issue #10: Fixed NPE in S7PlcConnection#close. URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-410170620 Ok ... so I just checked in the version I was talking about. It is basically structurally equal to the way we are doing things in the connection part. Also I just had a look at your change ... seems we are doing the same thing, but I would like to stick to CompletableFutures as your option is just doing the same but with a different syntax.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
