JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close. URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-410172284 @chrisdutz I guess due to my partial scala background I totally ignore Javas Completable futures as superior and thus didnt think about using them : D But I agree that it shows the intention of the code clearer. Perhaps we add a Util Class that "converts" a Netty Future into a Completable Future, as we surely need this functionality more often. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
