chrisdutz commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213981675
##########
File path:
plc4j/api/src/test/java/org/apache/plc4x/java/api/connection/PlcReaderTest.java
##########
@@ -38,24 +36,24 @@ Licensed to the Apache Software Foundation (ASF) under one
public class PlcReaderTest {
- @Test
+/* @Test
Review comment:
Well the API is currently just interfaces ... how do you test them? ... and
that's why there's a WIP in the Pull-Request as I will probably move these to
driver-base where the real datatypes will be. I commented them out so I can
compile the parts I have migrated and don't have to fetch them from the history
when re-adding them somewhere else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
