sruehl commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r214035318
##########
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcFieldRequest.java
##########
@@ -20,11 +20,13 @@ Licensed to the Apache Software Foundation (ASF) under one
import org.apache.plc4x.java.api.model.PlcField;
-import java.util.Collection;
+import java.util.LinkedHashSet;
public interface PlcFieldRequest extends PlcRequest {
- Collection<String> getFieldNames();
+ int getNumFields();
+
+ LinkedHashSet<String> getFieldNames();
Review comment:
as this is an interface, is there any reason to use `LinkedHashSet`? As you
said earlier if the order is important maybe the `java.util.SortedSet` might be
more appropriate. Even the `java.util.NavigatableSet` might be an option. Sonar
might highlight the issue later anway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
