Hi Julian, yeah ... the Field parser ... it's a lot more complex now, but I didn't put that much effort into it as you wanted to implement the Antlr4 parser __ I thought it was a waste of time to fine-tune something that was going to be replaced anyway ..
Will have a look and merge asap. Chris Am 17.09.18, 10:31 schrieb "Julian Feinauer" <[email protected]>: Hi Chris, thanks for the merge, the new api looks way better than the old one. I already updated my OPM branch to the new API and one thing I noticed is that we did no longer throw a Checked Exception on wront user input (Query String). Thus I opened a PR (https://github.com/apache/incubator-plc4x/pull/21) where I made the PlcInvalidFieldException checked (as the previous one, IllegalAdress or something was) and added also an UncheckedInvalidFieldExeption (similar than UncheckedIOException in Java 8) to enable smooth usage in Lambdas. Then I refactored all places where Fields are parsed and added the checked Exception. I hope that everyone agrees with the change but I think we should notify users at places where their input can lead to exceptions to force handling. Best Julian Am 17.09.18, 09:19 schrieb "Christofer Dutz" <[email protected]>: Hi all, I just wanted to tell you that I just merged the API refactoring branch back to master ... so now the API changes are live. Chris
