sruehl commented on a change in pull request #40: Alias registry for opm
URL: https://github.com/apache/incubator-plc4x/pull/40#discussion_r235885790
##########
File path:
plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityInterceptor.java
##########
@@ -135,13 +141,16 @@ public static Object intercept(@This Object proxy,
@Origin Method method, @Super
* Renews all values of all Fields that are annotated with {@link
PlcEntity}.
*
* @param proxy Object to refresh the fields on.
- * @param driverManager
+ * @param driverManager Driver Manager to use
+ * @param registry AliasRegistry to use
+ * @param lastFetched
* @throws OPMException on various errors.
*/
@SuppressWarnings("squid:S1141") // Nested try blocks readability is okay,
move to other method makes it imho worse
- static void refetchAllFields(Object proxy, PlcDriverManager driverManager,
String address) throws OPMException {
+ static void refetchAllFields(Object proxy, PlcDriverManager driverManager,
String address, AliasRegistry registry, Map<String, Instant> lastFetched)
throws OPMException {
// Don't log o here as this would cause a second request against a plc
so don't touch it, or if you log be aware of that
Class<?> entityClass = proxy.getClass().getSuperclass();
+ LOGGER.trace("Refetching all fields on proxy object of class " +
entityClass);
Review comment:
string formatting see other comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
