sruehl commented on a change in pull request #40: Alias registry for opm
URL: https://github.com/apache/incubator-plc4x/pull/40#discussion_r235885235
##########
File path:
plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/OpmUtils.java
##########
@@ -42,4 +48,41 @@ private OpmUtils() {
return annotation;
}
+ static String getOrResolveAddress(AliasRegistry registry, String
addressString) {
+ if (!OpmUtils.isValidExpression(addressString)) {
Review comment:
the `OpmUtils.` seems redundant as we are in this context anyway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
