JulianFeinauer commented on issue #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#issuecomment-470009105 Hey @timbo2k I'm pretty impressed by your work (especially I like the syntax we now have for the triggering modes). I added a lot of small points which are mostly no-brainers to fix. If we add some more tests I think we are ready to merge ASAP!. Very well done 👍
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
