JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822320
##########
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/ScraperConfiguration.java
##########
@@ -26,24 +26,32 @@
import com.fasterxml.jackson.databind.exc.MismatchedInputException;
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
import org.apache.plc4x.java.scraper.ScrapeJob;
-import org.apache.plc4x.java.scraper.Scraper;
+import org.apache.plc4x.java.scraper.ScrapeJobImpl;
+import org.apache.plc4x.java.scraper.exception.ScraperConfigurationException;
+import org.apache.plc4x.java.scraper.exception.ScraperException;
+import org.apache.plc4x.java.scraper.ScraperImpl;
+import
org.apache.plc4x.java.scraper.config.triggeredscraper.TriggeredJobConfiguration;
+import org.apache.plc4x.java.scraper.triggeredscraper.TriggeredScrapeJobImpl;
import java.io.File;
import java.io.FileNotFoundException;
import java.io.IOException;
+import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.function.Function;
import java.util.stream.Collectors;
/**
- * Configuration class for {@link Scraper}.
+ * Configuration class for {@link ScraperImpl}.
+ * Scraper is deprecated please use {@link
org.apache.plc4x.java.scraper.config.triggeredscraper.TriggeredScraperConfiguration}
instead all functions are supplied as well see java-doc of {@link
org.apache.plc4x.java.scraper.triggeredscraper.TriggeredScraperImpl}
Review comment:
@deprecated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
