timbo2k commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r263079012
########## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandler/TriggerConfiguration.java ########## @@ -0,0 +1,342 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.plc4x.java.scraper.triggeredscraper.triggerhandler; + +import org.apache.plc4x.java.api.exceptions.PlcInvalidFieldException; +import org.apache.plc4x.java.s7.model.S7Field; +import org.apache.plc4x.java.scraper.exception.ScraperException; +import org.apache.plc4x.java.scraper.triggeredscraper.TriggeredScrapeJobImpl; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +/** + * basic configuration for all available triggers and handling of regarding condition + */ +public class TriggerConfiguration{ + private static final Logger logger = LoggerFactory.getLogger(TriggerConfiguration.class); + + private static final String S_7_TRIGGER_VAR = "S7_TRIGGER_VAR"; Review comment: the triggering i made was explicit for S7 variable therefore the naming --> will be improved as much more generic within https://issues.apache.org/jira/browse/PLC4X-89 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
