JulianFeinauer commented on a change in pull request #57: Feature/plc4 x 108
ping method
URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270379357
##########
File path:
plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConnection.java
##########
@@ -57,6 +67,42 @@ public boolean canSubscribe() {
return false;
}
+ /**
+ * The default implementation uses the {@link #ping(int)} method.
+ * Drivers that want to implement a more specific version have to overide
it.
+ */
+ @Override
+ public boolean isConnected() {
+ return ping(PING_TIMEOUT_MS);
Review comment:
will add a todo, as I'm unsure if we should do that or not...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
