Hi all, +1 (binding)
I checked: - Readme - License - No unexpected assets - Built on Windows 10 x86 64 bit with “maven install -P with-java” Greetings Matthias Strljic, M.Sc. Universität Stuttgart Institut für Steuerungstechnik der Werkzeugmaschinen und Fertigungseinrichtungen (ISW) Seidenstraße 36 70174 Stuttgart GERMANY Tel: +49 711 685-84530 Fax: +49 711 685-74530 E-Mail: matthias.strl...@isw.uni-stuttgart.de Web: http://www.isw.uni-stuttgart.de -----Ursprüngliche Nachricht----- Von: Julian Feinauer <j.feina...@pragmaticminds.de> Gesendet: Wednesday, October 30, 2019 12:42 PM An: dev@plc4x.apache.org Betreff: Re: [VOTE] Apache PLC4X 0.5.0 RC3 Hi all, +1 (binding) I checked: - Checked out using tooling - Checked Signatures and Hashes - Checked README, RELEASE_NOTES, LICENSE and NOTICE - Checked README and RELEASE_NOTES are same as in the zip - No unexpected binaries - Builts on my MAC according to documentation in README (`mvn clean install -Pwith-java`) Julian Am 29.10.19, 16:32 schrieb "Christofer Dutz" <christofer.d...@c-ware.de>: +1 (binding) Chris All checks performed: * Checked out using the tooling: OK * Checked signatures: OK * Signed by apache email address: OK * Checked hashes: OK * Checked the zip correctly unpacks to the expected directory structure: OK * README.md and RELEASE_NOTES in the zip are identical to the ones in the release directory: OK * verify the existence of LICENSE, NOTICE, README.md, RELEASE_NOTES: OK * Checked the contents of LICENSE, NOTICE, README.md, RELEASE_NOTES: OK * No usage of SNAPSHOT versions: OK * All files have license headers (Checked via external RAT: java -Xms1024m -Xmx1024m -jar {path-to-rat}/apache-rat-0.13.jar . | grep "?????"): OK (json files can’t have headers, Expression.h has a manual license header in it, stating it’s UNLICENCEd) * No non-image binaries or unlicensed code (Checked via external RAT: java -Xms1024m -Xmx1024m -jar {path-to-rat}/apache-rat-0.13.jar . | grep " B "): OK (Binaries are only images, pdf files or PCAP files) + * Built from sources (including tests and all profiles activated) according to instructions in README.md: (MINOR) (With Java 13 I got errors in the plc4j-api tests ... had to downgrade to Java 12, but that worked perfectly) ** Mac: OK ** Linux: OK (Had to run the build with elevated privileges as access to raw-sockets is only available to root) * All tests pass: OK ** Mac: OK ** Linux: OK (When run as root) PS: Windows test is still running and I have to abort it in order to go home … being able to run full tests on Linux and Mac was good enough for me. Von: Christofer Dutz <christofer.d...@c-ware.de> Datum: Dienstag, 29. Oktober 2019 um 14:04 An: "dev@plc4x.apache.org" <dev@plc4x.apache.org> Betreff: [VOTE] Apache PLC4X 0.5.0 RC3 Apache PLC4X 0.5.0 RC3 has been staged under [2] and it’s time to vote on accepting it for release. All Maven artifacts are available under [1]. Voting will be open for 72hr. A minimum of 3 binding +1 votes and more binding +1 than binding -1 are required to pass. Release tag: release/0.5.0-rc3 Hash for the release tag: 59cd9d3839dcb6083350144802142360182c59c1 Per [3] "Before voting +1 PMC members are required to download the signed source code package, compile it as provided, and test the resulting executable on their own platform, along with also verifying that the package meets the requirements of the ASF policy on releases." You can achieve the above by following [4]. [ ] +1 accept (indicate what you validated - e.g. performed the non-RM items in [4]) [ ] -1 reject (explanation required) [1] https://repository.apache.org/content/repositories/orgapacheplc4x-1018 [2] https://dist.apache.org/repos/dist/dev/plc4x/0.5.0/rc3 [3] https://www.apache.org/dev/release.html#approving-a-release [4] https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release
