Hi people, first of all thanks for the amazing project that you are doing.
I have an issue with the 0.7.0 version when I'm using S7 driver. The regex
of the pattern doesn't match so I got this error: Caused by:
java.lang.IllegalArgumentException: s7://192.168.1.200/0/1 doesn't match


https://github.com/apache/plc4x/blob/1e6df7563ad909d365d1402729699b61c70019bd/plc4j/tools/connection-pool/src/main/java/org/apache/plc4x/java/utils/connectionpool/PoolKeyFactory.java#L46

[image: image.png]

This regex is correct but In version 0.7.0 I found this one in
PoolKeyFactory class:

private final Pattern s7URIPattern =
Pattern.compile("^(?<poolablePart>s7://((?<ip>[0-9]{1,3}.[0-9]{1,3}.[0-9]{1,3}.[0-9]{1,3})|(?<hostname>[a-zA-Z0-9\\.\\-]+))(:(?<port>[0-9]{1,5}))?)(?<params>\\?.*)?");

that doesn't match : s7://192.168.1.200/0/1 (With no rack nor slot)

Do you know if there is an issue here?

Thanks in advance.

Gerardo Melia

Reply via email to