Hi, +1 (non-binding)
I checked: [OK] Download all staged artifacts under the url specified in the release vote email [OK] Verify the signature is correct: Additional Apache tutorial on how to verify downloads can be found here [OK] Check if the check is successful [OK] Check if the signature references an Apache email address [OK] Verify the SHA512 hashes [OK] Unzip the archive [OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle [OK] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle [OK] Search for SNAPSHOT references [OK] Search for Copyright references [OK] Build the project according to the information in the README.md file Built with Windows 10 under WSL2/Ubuntu Dominik -----Original Message----- From: Ben Hutcheson <ben.hut...@gmail.com> Sent: Tuesday, January 26, 2021 11:22 AM To: dev@plc4x.apache.org Subject: Re: [VOTE] Apache PLC4X 0.8.0 RC2 +1 (binding) Ben Remarks, We could certainly do with some cleaning up of the documentation and build instructions e.g. the with-proxies switch doesn't exist anymore, there is a with-opcua-werver switch in the dockerfile, clang is required to build the c stuff but isn't listed. It probably isn't a good idea to use the 0.8.0-SNAPSHOT references in the cpp module pom, will this snapshot exist once we move to 0.9-SNAPSHOT? What is the folder plc4j/protocols for? can we get rid of it? it has some 0.8.1-SNAPSHOT references. with-cpp does build if I change it to use the 0.8.0 release. Built with mvn -P with-go,with-boost,with-logstash,with-proxies,with-python,with-sandbox install -Dmaven.repo.local=../.m2 on Apache Maven 3.6.3 Maven home: /usr/share/maven Java version: 11.0.10-ea, vendor: Debian, runtime: /usr/lib/jvm/java-11-openjdk-amd64 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.10.0-1-amd64", arch: "amd64", family: "unix" On Tue, Jan 26, 2021 at 2:25 AM Lukas Ott <ott.lukas...@gmail.com> wrote: > +1 (binding) > > Lukas > > Built on Ubuntu 20.04 with "mvn -P with-go install" > openjdk 11.0.9.1 2020-11-04 > Maven 3.6.3 > > [OK] Download all staged artifacts under the url specified in the > release vote email [OK] Verify the signature is correct: Additional > Apache tutorial on how to verify downloads can be found here [OK] > Check if the check is successful [OK] Check if the signature > references an Apache email address [OK] Verify the SHA512 hashes [OK] > Unzip the archive [OK] Verify the existence of LICENSE, NOTICE, > README, RELEASE_NOTES files in the extracted source bundle [OK] Verify > the content of LICENSE, NOTICE, README, RELEASE_NOTES files in the > extracted source bundle [OK] [RM] Verify the staged source README, > RELEASE_NOTE files correspond to those in the extracted source bundle > [OK] [RM] Run RAT externally to ensure there are no surprises [OK] > Search for SNAPSHOT references [OK] Search for Copyright references > [OK] Build the project according to the information in the README.md > file > > Am Mo., 25. Jan. 2021 um 21:59 Uhr schrieb Christofer Dutz < > christofer.d...@c-ware.de>: > > > +1 (binding) > > > > Chris > > > > Built on Windows 10 > > Open-JDK 11 > > Maven 3.6.3 > > > > [OK] Download all staged artifacts under the url specified in the > > release vote email [OK] Verify the signature is correct: Additional > > Apache tutorial on how > to > > verify downloads can be found here > > [OK] Check if the check is successful [OK] Check if the signature > > references an Apache email address [OK] Verify the SHA512 hashes > > [OK] Unzip the archive [OK] Verify the existence of LICENSE, NOTICE, > > README, RELEASE_NOTES files in the extracted source bundle [OK] > > Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files > in > > the extracted source bundle > > [OK] [RM] Verify the staged source README, RELEASE_NOTE files > > correspond to those in the extracted source bundle [OK] [RM] Run RAT > > externally to ensure there are no surprises [OK] Search for SNAPSHOT > > references [OK] Search for Copyright references [OK] Build the > > project according to the information in the README.md file [MINOR] > > [RM] Build the project with all with-xyz profiles and tests enabled > > and an empty maven local repo: by appendng > > -Dmaven.repo.local=../.m2. > > > > Remark: > > I built without the with-cpp,with-boost module as building boost > > doesn't work on my machine (But PLC4Cpp doesn't have any use anyway) > > > > -----Ursprüngliche Nachricht----- > > Von: Christofer Dutz <christofer.d...@c-ware.de> > > Gesendet: Montag, 25. Januar 2021 21:14 > > An: dev@plc4x.apache.org > > Betreff: [VOTE] Apache PLC4X 0.8.0 RC2 > > > > Apache PLC4X 0.8.0 has been staged under [2] and it's time to vote > > on accepting it for release. All Maven artifacts are available under [1]. > > Voting will be open for 72hr. > > > > A minimum of 3 binding +1 votes and more binding +1 than binding -1 > > are required to pass. > > > > Release tag: v0.8.0 > > Hash for the release tag: ebd0d6cba987c6aa708f1aec3ab45d0f0ae4184d > > > > Per [3] "Before voting +1 PMC members are required to download the > > signed source code package, compile it as provided, and test the > > resulting executable on their own platform, along with also > > verifying that the package meets the requirements of the ASF policy on > > releases." > > > > You can achieve the above by following [4]. > > > > [ ] +1 accept (indicate what you validated - e.g. performed the > > non-RM items in [4]) [ ] -1 reject (explanation required) > > > > > > [1] > https://repository.apache.org/content/repositories/orgapacheplc4x-1033 > > [2] https://dist.apache.org/repos/dist/dev/plc4x/0.8.0/rc2 > > [3] https://www.apache.org/dev/release.html#approving-a-release > > [4] > > > https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+ > Release > > > > >
