ottobackwards commented on a change in pull request #257:
URL: https://github.com/apache/plc4x/pull/257#discussion_r695040451
##########
File path:
plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/util/Plc4xCommon.java
##########
@@ -145,5 +155,100 @@ public static Schema createSchema(Map<String, ? extends
PlcValue> responseDataSt
}
-
+
Review comment:
@chrisdutz this seems very clumsy. For almost all of these you just
want to return whatever the "real" type of the value is. Is there no function
where you can get that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
