inigoao commented on a change in pull request #257:
URL: https://github.com/apache/plc4x/pull/257#discussion_r735680252
##########
File path:
plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/util/Plc4xCommon.java
##########
@@ -89,8 +90,8 @@ public static Schema createSchema(Map<String, ? extends
PlcValue> responseDataSt
builder.name(fieldName).type().unionOf().nullBuilder().endNull().and().intType().endUnion().noDefault();
}else if (entry.getValue() instanceof PlcLINT) {
builder.name(fieldName).type().unionOf().nullBuilder().endNull().and().stringType().endUnion().noDefault();
- }else if (entry.getValue() instanceof PlcList) {
-
builder.name(fieldName).type().unionOf().nullBuilder().endNull().and().stringType().endUnion().noDefault();
+// }else if (entry.getValue() instanceof PlcList) {
Review comment:
we will ask on the dev-mailing list to check if this method of doing
datatype mappings is the best one.. after this verification, we will clean all
this commented code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
