Hi Lukasz, thanks for bringing this up ... I mentioned it on slack too. I am very happy with all of the recent extensions, but also we already had first support requests from people trying to use the subscription on non-compatible devices. So I would also like to see the driver more context aware ... we already do the identification as part of the connection process and should be easily available to the driver implementation. If this identification doesn't identify all types of devices (You mentioned some non-s7 devices) I am happy to help with extending the auto-detection.
The S7DriverContext type has a controllerType enum value for this ... if the Enum S7ControllerType needs any addition, feel free to add them. Chris -----Ursprüngliche Nachricht----- Von: Łukasz Dywicki <l...@code-house.org> Gesendet: Mittwoch, 17. November 2021 09:33 An: dev@plc4x.apache.org Betreff: Re: Driver PLC4J S7 Hey Cesar, I see that you do awesome progress with all complicated parts of S7 communication. By looking at code and updated docs I see that most of this functionality is intended for S7-400 and will not work with low end S7-1200. This brings me to a question if our present "PlcConnection.canSubscribe()" method is sufficient to let know user application that it can subscribe? Does it return false for S7-1200 and true for 300 and 400? Main question is how we could keep user applications aware of subscription possibilities without complicating PLC4X end too much. If subscription support is similar (alarm, mode, user) and available only in higher end models then we can live with current APIs, but if subscription support vary between models we need to think how to express that to end user. After all doing a subscription request which fails is least effective way to find that driver and connected plc does not support specific subscription kind. Best, Łukasz śr., 17 lis 2021 o 06:43 Cesar Garcia <cesar.gar...@ceos.com.ve> napisał(a): > Hello, > > This PR includes the following features for the S7 driver. > > 1. Subscribe to Alarm8. > 2. Recognition of events. > 3. Alarm text processing. > 4. Subscription to cyclical values. > 5. Diagnostic Record Readings (SZL). > 6. Proposal for documentation. > > Thank you very much for your support in the documentation proposal, > several sections are missing, but I think your observations are > extremely important. > > Best regards, > > -- > *CEOS Automatización, C.A.* > *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,* *PISO 1, OFICINA 2, > AV. RAUL LEONI, SECTOR GUAMACHITO,* > > *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI* *Ing. > César García* > > *Cel: +58 414-760.98.95* > > *Hotline Técnica SIEMENS: 0800 1005080* > > *Email: support.aan.automat...@siemens.com > <support.aan.automat...@siemens.com>* >
