Hello Chris,
What you asking for might effectively stop any contributions to protocol
updates for entire project. There are very few people who can do Java,
C, Go and eventually Python. I know one of goals of Apache PLC4X is
supporting variety of languages, but what you suggest mean that less
and less people will be able contribute mspec fixes. There will be even
less of them with each next language we introduce..
While I understand it is important to keep consistency, reality is we
have far less people working on C than on Java. Some of languages we
have code generators and drivers for, did and will fall behind.
I'd rather opt for keeping mspecs releases separate from drivers so
plc4j/plc4c and plc4go can pick version they support and stick with it.
This is the way in which we can avoid troubles with new changes which
are implemented in one language but not others. What do you think about
that?
Best,
Łukasz
On 3.05.2023 16:42, Christofer Dutz wrote:
Hi all,
we’re currently trying to get the S7 driver back working ... even if it seems
as if it is working (When running the ManualS7Test) ... None of the
Integration-Tests are running, because all are disabled.
This makes quality assurance quite difficult.
Also, the fact that the changes broke the C and the Go versions is “sub-ideal”.
We’ll try to fix the problems, but I guess it’s going to consume a lot of time
to do so.
But in the future ... if you change mspecs for drivers, you might break things
in other languages, so It’s super important to ensure stuff is working in all
languages.
Also please don’t comment out tests ... I know I found a place where I did so
too and I promise to not do it again.
We really have to pay a bit more attention on not reducing more and more of our
tests.
Chris
