sruehl commented on code in PR #1088:
URL: https://github.com/apache/plc4x/pull/1088#discussion_r1311253205
##########
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/values/PlcNull.java:
##########
@@ -271,6 +271,21 @@ public PlcValue getValue(String key) {
return null;
}
+ @Override
+ public Map<String, PlcValue> getMetaData() {
+ return null;
Review Comment:
Maybe provide a `collections.emptyMap()` (or however this is called, might
be a static variable too) just to avoid NPEs when calling it
##########
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/values/PlcNull.java:
##########
@@ -271,6 +271,21 @@ public PlcValue getValue(String key) {
return null;
}
+ @Override
+ public Map<String, PlcValue> getMetaData() {
+ return null;
Review Comment:
or if it extends PLC Value adapter remove those implementations here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
